Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

refactor: 100KB+ logo => 14KB logo, dedupe asset #559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: 100KB+ logo => 14KB logo, dedupe asset #559

wants to merge 1 commit into from

Conversation

cdaringe
Copy link
Contributor

@cdaringe cdaringe commented Dec 19, 2021 •
edited
Loading

Problem

  • two logo files present on the same page, both downloaded, for the same usage intent
  • both files are ~108KB

Solution

  • dedupe files
  • get logo down to 14KB

Modified relative paths:

https://v3-ocaml-org-git-fork-cdaringe-refactor-improved-logos-ocaml.vercel.app/

Contributor Pre-flight Checklist

  • Accessibility check - checked pa11y report for modified pages, observing new errors
  • Responsive check - visually inspected vercel preview, using responsive tool to toggle between desktop and mobile view
  • HTML review - use browser DOM/Page inspector to inspect generated HTML within <div id="__next>" element

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cdaringe